Michael Pasternak has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 19: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 2157: <xs:element ref="port_mirroring" minOccurs="0"
maxOccurs="1"/>
i see, but where you plan to put it in the network itself?
<port_mirroring>
<network>
<name>x</name>
<traffic_forward>y</traffic_forward>
</network>
</port_mirroring>
if yes, we using collection pattern, the xsd modelling will be:
<xs:element name="port_mirroring" type="PortMirroring"/>
<xs:complexType name="PortMirroring">
<xs:sequence>
<xs:element name="enabled" type="xs:boolean" minOccurs="0" maxOccurs="1"/>
[1]
<xs:element ref="networks" minOccurs="0" maxOccurs="1"/> [2]
</xs:sequence>
</xs:complexType>
what will produce:
<port_mirroring>
<enabled>true|false</enabled> [1]
<networks> [2]
<network>
<name>x</name>
<traffic_forward>y</traffic_forward>
</network>
</networks>
</port_mirroring>
note:
====
[1] i have added <enabled> element which will allow you to switch on/off p.m
[2] i'm using already existent type <networks>, you only have to reference it
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
