Shahar Havivi has posted comments on this change.
Change subject: rest: Add Port Mirroring to VM interface
......................................................................
Patch Set 24: (4 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 52:
device.getPortMirroring().getNetworks().getNetworks().get(0).isSetId()
comment in NicMapper
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicsResource.java
Line 69: &&
Comment in NicMapper
....................................................
File
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/NicMapper.java
Line 76: net.setName(entity.getNetworkName());
We don't have the network_id here...
the VmNetworkInterface have only network_name.
so what do you suggest?
....................................................
Commit Message
Line 17: <network href="/api/networks/{network-id}"
id="{network-id}"/>
no, Id
or else we have to do round trip to the engine
--
To view, visit http://gerrit.ovirt.org/3727
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic03d841d6d0f6cb7250a25e43bdda3d3e9b7488b
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
