Kanagaraj M has posted comments on this change. Change subject: webadmin : Gluster Volume Profile ......................................................................
Patch Set 38: (7 comments) http://gerrit.ovirt.org/#/c/27470/38/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java: Line 160: VdcQueryReturnValue vdcValue = (VdcQueryReturnValue) returnValue; Line 161: GlusterVolumeProfileInfo profileInfoEntity =vdcValue.getReturnValue(); Line 162: if((profileInfoEntity == null) || (!vdcValue.getSucceeded())) { Line 163: setSuccessfulProfileStatsFetch(false); Line 164: stopProgress(); progress is already stopped Line 165: if(!isBrickSelected) { Line 166: showNfsProfileStats(profileInfoEntity); Line 167: } else { Line 168: showProfileStats(profileInfoEntity); Line 169: } Line 170: } else { Line 171: setProfileInfo(profileInfoEntity); Line 172: setSuccessfulProfileStatsFetch(true); Line 173: if(getWindow() == null) { why this check required? Line 174: setTitle(ConstantsManager.getInstance().getMessages().volumeProfilingStatsTitle(volumeName)); Line 175: if(!isBrickSelected) { Line 176: showNfsProfileStats(profileInfoEntity); Line 177: } else { Line 179: } Line 180: } Line 181: } Line 182: } Line 183: }), clusterId, volumeId, nfs); instead of nfs you can use !isBrickSelected Line 184: } Line 185: Line 186: public void showProfileStats(GlusterVolumeProfileInfo entity) { Line 187: if (entity != null) { Line 186: public void showProfileStats(GlusterVolumeProfileInfo entity) { Line 187: if (entity != null) { Line 188: final List<BrickProfileDetails> brickProfileDetails = entity.getBrickProfileDetails(); Line 189: getBricks().setItems(brickProfileDetails); Line 190: getBricks().setSelectedItem(brickProfileDetails.get(0)); better to check the size of the list before doing get(0) Line 191: } Line 192: } Line 193: Line 194: private void populateCummulativeStatistics(List<FopStats> fopStats, ListModel profileStats) { Line 200: profileStats.setItems(fopStatsEntities); Line 201: } Line 202: Line 203: public void showNfsProfileStats(GlusterVolumeProfileInfo entity) { Line 204: final List<GlusterVolumeProfileStats> nfsProfileDetails = entity.getNfsProfileDetails(); is this final required? Line 205: getNfsServers().setItems(nfsProfileDetails); Line 206: getNfsServers().setSelectedItem(nfsProfileDetails.get(0)); Line 207: } Line 208: Line 202: Line 203: public void showNfsProfileStats(GlusterVolumeProfileInfo entity) { Line 204: final List<GlusterVolumeProfileStats> nfsProfileDetails = entity.getNfsProfileDetails(); Line 205: getNfsServers().setItems(nfsProfileDetails); Line 206: getNfsServers().setSelectedItem(nfsProfileDetails.get(0)); same here Line 207: } Line 208: Line 209: private String formatRunTime(UIMessages messages, Pair<Integer, String> runTimeConverted, Pair<Integer, String> intervalRunTimeConverted) { Line 210: return messages.glusterVolumeCurrentProfileRunTime(intervalRunTimeConverted.getFirst(), intervalRunTimeConverted.getSecond(), runTimeConverted.getFirst(), runTimeConverted.getSecond()); Line 226: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 227: super.eventRaised(ev, sender, args); Line 228: int index = 0; Line 229: UIMessages messages = ConstantsManager.getInstance().getMessages(); Line 230: if(ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition) && sender == getBricks()) { why not to do something like getBricks().getSelectedItemChangedEvent().addListener ? Line 231: if(getBricks().getSelectedItem() != null) { Line 232: index = getProfileInfo().getBrickProfileDetails().indexOf(getBricks().getSelectedItem()); Line 233: } Line 234: List<BrickProfileDetails> profileStats = getProfileInfo().getBrickProfileDetails(); -- To view, visit http://gerrit.ovirt.org/27470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033 Gerrit-PatchSet: 38 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
