Kanagaraj M has posted comments on this change. Change subject: webadmin : Gluster Volume Profile ......................................................................
Patch Set 40: (3 comments) http://gerrit.ovirt.org/#/c/27470/40/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java: Line 590: } else if(command.equals(getShowVolumeProfileDetailsCommand()) || command.getName().equals("showProfileDetails")) {//$NON-NLS-1$ Line 591: showVolumeProfiling(); Line 592: }else if(command.getName().equalsIgnoreCase("closeProfileStats")) {//$NON-NLS-1$ Line 593: setWindow(null); Line 594: } else if(command.getName().equalsIgnoreCase("profilingNotStarted")) {//$NON-NLS-1$ is this being used? Line 595: onProfileNotStartedError(); Line 596: } Line 597: } Line 598: Line 788: } Line 789: Line 790: public void setProfileWindow(VolumeProfileStatisticsModel profileStatsModel) { Line 791: final ConfirmationModel cModel = (ConfirmationModel)getConfirmWindow(); Line 792: if(cModel != null) { is this being used? Line 793: cModel.stopProgress(); Line 794: setConfirmWindow(null); Line 795: } Line 796: if(getWindow() == null) { http://gerrit.ovirt.org/#/c/27470/40/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeProfileStatisticsPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeProfileStatisticsPopupView.java: Line 276: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 277: PropertyChangedEventArgs e = (PropertyChangedEventArgs) args; Line 278: if (e.propertyName.equals("brickProfileRunTimeChanged")) {//$NON-NLS-1$ Line 279: profileRunTime.setText(object.getProfileRunTime()); Line 280: profileRunTime.setVisible(true); where is setVisible(false) Line 281: } Line 282: if (e.propertyName.equals("brickProfileDataRead")) {//$NON-NLS-1$ Line 283: bytesRead.setText(object.getBytesRead()); Line 284: bytesRead.setVisible(true); -- To view, visit http://gerrit.ovirt.org/27470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
