Kanagaraj M has posted comments on this change. Change subject: webadmin : Gluster Volume Profile ......................................................................
Patch Set 40: (3 comments) http://gerrit.ovirt.org/#/c/27470/40/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeProfileStatisticsModel.java: Line 138: setNfsServers(new ListModel<GlusterVolumeProfileStats>()); Line 139: final UIMessages messages = ConstantsManager.getInstance().getMessages(); Line 140: getBricks().getSelectedItemChangedEvent().addListener(new IEventListener() { Line 141: @Override Line 142: public void eventRaised(Event ev, Object sender, EventArgs args) { please extract the below to a separate method Line 143: int index = 0; Line 144: if(ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { Line 145: if(getBricks().getSelectedItem() != null) { Line 146: index = getProfileInfo().getBrickProfileDetails().indexOf(getBricks().getSelectedItem()); Line 140: getBricks().getSelectedItemChangedEvent().addListener(new IEventListener() { Line 141: @Override Line 142: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 143: int index = 0; Line 144: if(ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { this check is not required Line 145: if(getBricks().getSelectedItem() != null) { Line 146: index = getProfileInfo().getBrickProfileDetails().indexOf(getBricks().getSelectedItem()); Line 147: } Line 148: List<BrickProfileDetails> profileStats = getProfileInfo().getBrickProfileDetails(); Line 164: getNfsServers().getSelectedItemChangedEvent().addListener(new IEventListener() { Line 165: @Override Line 166: public void eventRaised(Event ev, Object sender, EventArgs args) { Line 167: int index = 0; Line 168: if(ev.matchesDefinition(ListModel.selectedItemChangedEventDefinition)) { same here Line 169: index = 0; Line 170: if(getNfsServers().getSelectedItem() != null) { Line 171: index = getProfileInfo().getNfsProfileDetails().indexOf(getNfsServers().getSelectedItem()); Line 172: } -- To view, visit http://gerrit.ovirt.org/27470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic305a0fece18f29d24a9d0324391e484681fa033 Gerrit-PatchSet: 40 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
