Liron Aravot has posted comments on this change. Change subject: core: Report unreachable domain names when setting host as non operational ......................................................................
Patch Set 6: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28859/6/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java: Line 157: } else { Line 158: Map<String, String> customLogValues = new HashMap<>(); Line 159: customLogValues.put("StoragePoolName", getStoragePoolName()); Line 160: if (problematicDomains != null && !problematicDomains.isEmpty()) { Line 161: customLogValues.put("StorageDomainNames", StringUtils.join(Entities.objectNames(problematicDomains), ',')); consider change to ', ' (with space) when you rebase Line 162: } Line 163: setNonOperational(NonOperationalReason.STORAGE_DOMAIN_UNREACHABLE, customLogValues); Line 164: return false; Line 165: } -- To view, visit http://gerrit.ovirt.org/28859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dc385da76b6a4b0776d783c0df33fa737d206c0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
