Tal Nisan has posted comments on this change.

Change subject: core: Report unreachable domain names when setting host as non 
operational
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/28859/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java:

Line 324:         } catch (VdcBLLException e) {
Line 325:             log.errorFormat("Could not get Host statistics for Host 
{0}, Error is {1}",
Line 326:                     getVds().getName(),
Line 327:                     e);
Line 328:             returnValue.setFirst(false);
> there's a problem here, in case of reaching here, the audit log will be pri
I'll open a separate bug for that issue, it existed before, in case of a 
problem in fetching the stats both of the messages this one and the former will 
be inaccurate
Line 329:         }
Line 330:         return returnValue;
Line 331:     }
Line 332: 


-- 
To view, visit http://gerrit.ovirt.org/28859
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1dc385da76b6a4b0776d783c0df33fa737d206c0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to