Liron Aravot has posted comments on this change. Change subject: core: Report unreachable domain names when setting host as non operational ......................................................................
Patch Set 4: Code-Review+1 (2 comments) Minor issues inside. http://gerrit.ovirt.org/#/c/28859/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java: Line 126: } Line 127: ); Line 128: Line 129: for (Guid vdsId : vdsIdsToSetNonOperational) { Line 130: Map<String, String> customLogValues = Collections.singletonMap("StorageDomainNames", getStorageDomainName()); don't we need here also the StoragePoolName? (but that was present also before, so it can be fixed in further patch if you prefer) Line 131: SetNonOperationalVdsParameters tempVar = Line 132: new SetNonOperationalVdsParameters(vdsId, STORAGE_DOMAIN_UNREACHABLE, customLogValues); Line 133: tempVar.setStorageDomainId(getStorageDomain().getId()); Line 134: tempVar.setTransactionScopeOption(TransactionScopeOption.RequiresNew); http://gerrit.ovirt.org/#/c/28859/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1398: .vdsNonOperational(vdsId, Line 1399: NonOperationalReason.STORAGE_DOMAIN_UNREACHABLE, Line 1400: true, Line 1401: domainId, Line 1402: Collections.singletonMap("storageDomainNames", storageDomain.getStorageName())); /s/storageDomainNames/StorageDomainNames Line 1403: } Line 1404: }); Line 1405: Line 1406: nonOpVdss.add(vdsId); -- To view, visit http://gerrit.ovirt.org/28859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1dc385da76b6a4b0776d783c0df33fa737d206c0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
