Roy Golan has posted comments on this change. Change subject: core: Add engine-java script ......................................................................
Patch Set 3: (2 inline comments) .................................................... File packaging/fedora/engine-java.py Line 202: if item in files: you don't search in subdirectories? I don't see a use of children here. it should be a list of subdirs I guess. Line 205: children.sort() whats the use of the sort here? children will be overwritten the next iteration, no? maybe I am missing some python magic here -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
