Juan Hernandez has posted comments on this change. Change subject: core: Add engine-java script ......................................................................
Patch Set 3: (3 inline comments) .................................................... File Makefile Line 367: install -m 755 packaging/fedora/engine-java.py $(PREFIX)/usr/share/ovirt-engine/scripts No, but the next line creates a engine-java (without the .py extension) symlink in the /usr/bin directory, which is part of the path of every user. .................................................... File packaging/fedora/engine-java.py Line 202: if item in files: That is the magic of the os.walk function, it iterates a directory tree. For each directory in the tree it gives the parent directory, the list of child directories and the list of files. Line 205: children.sort() The os.walk function gives you a list of children directories. You can use it, and you can also modify it. If you modify it then the next call to os.walk will iterate the modified list. In this case I am sorting the list of directories in order to get a predictable behaviour, otherwise the search will depend on how the directories are internally stored by the operating system. Now that I think about it, what I should do is to sort also "files" before iterating, for the same reason. Will do that in the next patch set. -- To view, visit http://gerrit.ovirt.org/5129 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
