Juan Hernandez has posted comments on this change.
Change subject: core: Add engine-java script
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File Makefile
Line 367: install -m 755 packaging/fedora/engine-java.py
$(PREFIX)/usr/share/ovirt-engine/scripts
True, engine-java is very generic. I used that name because all the other
scripts we use have names like "engine-setup", "engine-cleanup",
"engine-service", so it was natural to select "engine-java". I would really
like to preserve that "engine-whatever". As the idea is to use this to launch
engine tools we could name it "engine-tool", "engine-tool-launcher",
"engine-java-launcher", "engine-java-tool", etc. Let me know what you think.
....................................................
File packaging/fedora/engine-java.py
Line 202: if item in files:
The os.walk function is really nice. Try this snippet in your python
interpreter:
import os
for tuple in os.walk("/etc"):
print(tuple)
--
To view, visit http://gerrit.ovirt.org/5129
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6eed7495f8d380656ef413596d7848618e395c96
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
