Sahina Bose has posted comments on this change.

Change subject: engine: gluster volume geo replication entities
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/29605/4/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeEntity.java:

Line 78:     private GlusterAsyncTask asyncTask;
Line 79: 
Line 80:     private GlusterVolumeAdvancedDetails advancedDetails;
Line 81: 
Line 82:     private boolean isGeoRepStarted;
> Needed it to enable/disable the actions in Geo-replication sub tab for a se
You should be looking at the geo-rep session status to get this information. I 
don't think we should store this here.
Line 83: 
Line 84:     public GlusterVolumeEntity() {
Line 85:         options = new LinkedHashMap<String, 
GlusterVolumeOptionEntity>();
Line 86:         bricks = new ArrayList<GlusterBrickEntity>();


-- 
To view, visit http://gerrit.ovirt.org/29605
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If86abee9276b8f2e4bdd4a4276dbbd76b9514c68
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Ramesh N <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: anmolbabu <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to