Tal Nisan has posted comments on this change. Change subject: core: filter candidate block Storage Domains with existing LUNs. ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/36079/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 98: return luns; Line 99: } Line 100: Line 101: private List<String> getPhysicalVolumesFromLunsList(List<LUNs> luns) { Line 102: List<String> physicalVolumeIds = new ArrayList<>(); You use this code twice, you can extract it to StorageUtils Line 103: for (LUNs lun : luns) { Line 104: physicalVolumeIds.add(lun.getphysical_volume_id()); Line 105: } Line 106: return physicalVolumeIds; http://gerrit.ovirt.org/#/c/36079/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQuery.java: Line 242: } Line 243: return storageDomains; Line 244: } Line 245: Line 246: private List<String> getPhysicalVolumesFromLunsList(List<LUNs> luns) { You use this code twice, you can extract it to StorageUtils Line 247: List<String> physicalVolumeIds = new ArrayList<>(); Line 248: for (LUNs lun : luns) { Line 249: physicalVolumeIds.add(lun.getphysical_volume_id()); Line 250: } -- To view, visit http://gerrit.ovirt.org/36079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id82e5e1d3df8ce265833efb3fc4b9050ca73b679 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
