Allon Mureinik has posted comments on this change. Change subject: core: filter candidate block Storage Domains with existing LUNs. ......................................................................
Patch Set 4: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/36079/4/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetUnregisteredBlockStorageDomainsQueryTest.java: Line 72: doReturn(storageDomainDAO).when(getQuery()).getStorageDomainDAO(); Line 73: doReturn(getExistingStorageDomains()).when(storageDomainDAO).getAll(); Line 74: Line 75: doReturn(lunDAO).when(getQuery()).getLunDAO(); Line 76: doReturn(new ArrayList<>()).when(lunDAO).getAll(); Use Collections.emptyLisy(). Also, I'd also add a test for a non-empty list. Line 77: } Line 78: Line 79: @Test Line 80: public void testIscsiFoundUnregisteredDomain() { -- To view, visit http://gerrit.ovirt.org/36079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id82e5e1d3df8ce265833efb3fc4b9050ca73b679 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
