Maor Lipchuk has posted comments on this change. Change subject: core: filter candidate block Storage Domains with existing LUNs. ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36079/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 56: } Line 57: Line 58: List<LUNs> physicalVolumeIdsOnStorage = getLUNsFromVgInfo(getStorageDomain().getStorage()); Line 59: if (CollectionUtils.containsAny(physicalVolumeIdsOnStorage, Line 60: getPhysicalVolumesFromLunsList(getDbFacade().getLunDao().getAll()))) { > As Allon stated: yes, missed that, fixing.. Line 61: log.info("There are existing luns in the system which are part of VG id '{}'", Line 62: getStorageDomain().getStorage()); Line 63: return failCanDoAction(VdcBllMessages.ACTION_TYPE_FAILED_IMPORT_STORAGE_DOMAIN_EXTERNAL_LUN_DISK_EXIST); Line 64: } -- To view, visit http://gerrit.ovirt.org/36079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id82e5e1d3df8ce265833efb3fc4b9050ca73b679 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
