Yair Zaslavsky has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 422: * @see VdsEventListener
Line 423: * @See VdsUpdateRunTimeInfo
Line 424: */
Line 425: @Override
Line 426: public void throttle() {
once again, don't use throttle
Line 427: if (log.isDebugEnabled()) {
Line 428: log.debug("try to wait for te engine update the host
memory and cpu stats");
Line 429: }
Line 430:
Line 430:
Line 431: decreaseLock.lock();
Line 432: try {
Line 433: // wait for the run-time refresh to decrease any current
powering-up VMs
Line 434: decreased.await(Config.<Integer>
GetValue(ConfigValues.VdsRefreshRate), TimeUnit.SECONDS);
Consult with SLA group about this - it effects VM scheduling.
Line 435: } catch (InterruptedException e) {
Line 436: // ignore
Line 437: } finally {
Line 438: decreaseLock.unlock();
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Throttler.java
Line 7: * Moreover bulk operations may cause a pick in VDSM resources
utilization and the engine can regulate <br>
Line 8: * the pace to enable <br>
Line 9: * Successful end of the operations.
Line 10: */
Line 11: public interface Throttler {
See previous comments. Even if you keep Throttler, the name is too "generic"
Line 12:
Line 13: public void throttle();
....................................................
Commit Message
Line 3: AuthorDate: 2012-08-15 10:48:36 +0300
Line 4: Commit: Roy Golan <[email protected]>
Line 5: CommitDate: 2012-08-15 11:07:01 +0300
Line 6:
Line 7: core: throttle running of VMs (#843058)
As we discussed - something else should be used, not throttle (Setting pace
of...? )
Line 8:
Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=843058
Line 10:
Line 11: Bulk running of VMs reguallary fail short in running all VMs. The
reason is
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
