Doron Fediuck has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Let's talk about it.
I think there are issues there we should try and avoid.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommandBase.java
Line 365: return true;
Line 366: }
Line 367:
Line 368: protected void DecreasePendingVms(Guid vdsId) {
Line 369: decreaseLock.lock();
Are you really locking everything until we get a response back from vdsm?
What happens if there's a network delay and we only get a response after 30
seconds? for each VM?
Line 370: try {
Line 371: boolean updateDynamic = false;
Line 372: VDS vds = DbFacade.getInstance().getVdsDAO().get(vdsId);
Line 373: if (vds == null)
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
