Omer Frenkel has posted comments on this change.
Change subject: core: throttle running of VMs (#843058)
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsFreeMemoryChecker.java
Line 17: }
Line 18:
Line 19: public boolean evaluate(VDS vds, VM vm) {
Line 20: // first check if this host has memory.
Line 21: if (!RunVmCommandBase.hasMemoryToRunVM(vds, vm)) {
i don't mind moving this code around,
but should not be part of this patch.
Line 22: if (log.isDebugEnabled()) {
Line 23: log.debug("not enough memory on host. throttling...");
Line 24: }
Line 25: // not enough memory to run the vm invoke the throttler.
--
To view, visit http://gerrit.ovirt.org/7204
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I076ede6cba919bc61f7546d7b29ef436eb6d3375
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
