Allon Mureinik has posted comments on this change. Change subject: webadmin: Preventing moving a shareable disk to a Gluster domain ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36359/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/MoveOrCopyDiskModel.java: Line 175: } Line 176: } Line 177: Line 178: private boolean isDiskValidForStorage(Disk disk, StorageDomain storage) { Line 179: if (disk.isShareable() && storage.getStorageType().equals(StorageType.GLUSTERFS)) { StorageType is an enum - it should be compared with == Line 180: return false; Line 181: } Line 182: return true; Line 183: } -- To view, visit http://gerrit.ovirt.org/36359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc2ea43f2131056c6f9ea86ecfb574fe71b638be Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
