Liron Aravot has posted comments on this change. Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf (#828192) ......................................................................
Patch Set 4: (3 inline comments) .................................................... Commit Message Line 6: Line 7: core: WIP : RemoveImageDisk - race when updating snapshots ovf (#828192) Line 8: Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=828192 Line 10: Done Line 11: when removing an image disk it should be removed from all the snapshots Line 12: it's contained within. the removal from the image snapshots includes an Line 13: update to the snapshot ovf (saved in the DB). the update is an Line 14: read-update-write operation, so when two or more disks are removed from Line 8: Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=828192 Line 10: Line 11: when removing an image disk it should be removed from all the snapshots Line 12: it's contained within. the removal from the image snapshots includes an Done Line 13: update to the snapshot ovf (saved in the DB). the update is an Line 14: read-update-write operation, so when two or more disks are removed from Line 15: the same snapshot a race condition might occur. Line 16: this patch adds a lock on the snapshot when performing the operations on Line 9: https://bugzilla.redhat.com/show_bug.cgi?id=828192 Line 10: Line 11: when removing an image disk it should be removed from all the snapshots Line 12: it's contained within. the removal from the image snapshots includes an Line 13: update to the snapshot ovf (saved in the DB). the update is an Done Line 14: read-update-write operation, so when two or more disks are removed from Line 15: the same snapshot a race condition might occur. Line 16: this patch adds a lock on the snapshot when performing the operations on Line 17: the snapshot ovf to prevent the race condition. -- To view, visit http://gerrit.ovirt.org/7482 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccb44f1aa9d204477955343167133849a4146753 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
