Ayal Baron has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 194: private final EngineLock snapshotEngineLock = new EngineLock();
Line 195: private final Map<String, String> snapshotsExlusiveLockMap = new
HashMap<String, String>();
Line 196:
Line 197: private void lockSnapshotWithWait(Guid snapshotId) {
Line 198: snapshotsExlusiveLockMap.clear();
This function seems entirely not thread safe to me. What am I missing?
Line 199: snapshotsExlusiveLockMap.put(snapshotId.toString(),
LockingGroup.SNAPSHOT.name());
Line 200:
snapshotEngineLock.setExclusiveLocks(snapshotsExlusiveLockMap);
Line 201: getLockManager().acquireLockWait(snapshotEngineLock);
Line 202: }
--
To view, visit http://gerrit.ovirt.org/7482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb44f1aa9d204477955343167133849a4146753
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
