Michael Kublin has posted comments on this change.
Change subject: core: WIP : RemoveImageDisk - race when updating snapshots ovf
(#828192)
......................................................................
Patch Set 7: (1 inline comment)
Really, that code looks good , that is code review needed in order to prove
different?
Bad idea of solution, bad performance, possible starvation, and as last a
problem will not be saved.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
Line 165: private void updateSnapshotConfigWithoutImage(Guid
imageGroupToRemove) {
Line 166: List<DiskImage> snapshotDisks =
getDiskImageDao().getAllSnapshotsForImageGroup(imageGroupToRemove);
Line 167: // shuffling the snapshots list so that every thread
performing the command on same snapshots will try to
Line 168: // acquire the locks on the snapshots in different order.
Line 169: Collections.shuffle(snapshotDisks);
Please explain what these means? I don't know what to write about what I think
about that code and still be political correct.
Line 170: for (DiskImage snapshotDisk : snapshotDisks) {
Line 171: NGuid vmSnapshotId = snapshotDisk.getvm_snapshot_id();
Line 172: if (vmSnapshotId != null &&
!Guid.Empty.equals(vmSnapshotId.getValue())) {
Line 173: try {
--
To view, visit http://gerrit.ovirt.org/7482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iccb44f1aa9d204477955343167133849a4146753
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
