Ravi Nori has posted comments on this change.

Change subject: aaa: add support for basic athentication
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.ovirt.org/#/c/37299/6/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/BasicAuthServlet.java
File 
backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/BasicAuthServlet.java:

Line 30:             
request.getSession(true).setAttribute(SSOUtils.USER_CREDENTIALS, credentials);
Line 31:             response.sendRedirect(request.getContextPath() + 
SSOUtils.LOGIN_PHASE2_URI);
Line 32:         } else if (enableBasicAuth) {
Line 33:             response.setHeader("WWW-Authenticate", "Basic realm=\"" + 
realm + "\"");
Line 34:             response.sendError(HttpServletResponse.SC_UNAUTHORIZED);
> I still unsure what happens when you press ESC after 1st attempt... from my
I get the jboss 401 page
Line 35:         } else {
Line 36:             response.sendRedirect(request.getContextPath() + 
SSOUtils.LOGIN_PHASE2_URI);
Line 37:         }
Line 38:     }


-- 
To view, visit http://gerrit.ovirt.org/37299
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If09285f0e6cd8909f21aa7e88ae1a3c1a30763c2
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to