Ravi Nori has posted comments on this change. Change subject: aaa: add support for basic athentication ......................................................................
Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/37299/6/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase2Servlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase2Servlet.java: Line 64: } catch (SQLException ex) { Line 65: log.error("Internal Database Error", ex); Line 66: throw new AuthenticationException("Internal Database Error", ex); Line 67: } Line 68: } catch (AuthenticationException ex) { > any reason we keep the AuthenticationException class? what is the advantage Having this exception and catching it lets us pass the authentication exception messages like "Password Expired" etc back to the user. Line 69: request.getRequestDispatcher("/WEB-INF/login.jsp?msg=" + ex.getMessage()).forward(request, response); Line 70: } finally { Line 71: request.getSession().removeAttribute(SSOUtils.USER_CREDENTIALS); Line 72: } -- To view, visit http://gerrit.ovirt.org/37299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09285f0e6cd8909f21aa7e88ae1a3c1a30763c2 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
