Alon Bar-Lev has posted comments on this change. Change subject: aaa: add support for basic athentication ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/37299/7/backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase1Servlet.java File backend/manager/modules/enginesso/src/main/java/org/ovirt/engine/core/sso/servlets/LoginPhase1Servlet.java: Line 26: Line 27: if (enableExternalAuth) { Line 28: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_EXTERNAL_URI); Line 29: } else if (acceptBasicAuth) { Line 30: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_BASIC_URI); hmmm... sorry to bother you about the sequence... but... external should be before basic, but if we require basic it should be in own phase... phase1 external phase2 - probably new if accept basic accept headers basic - if not authenticated yet and require basic phase3 - probably what was in phase2 if accept basic accept headers this will enable us to do the external magic and if that did not help prompt for basic. Line 31: } else { Line 32: response.sendRedirect(request.getContextPath() + SSOUtils.LOGIN_PHASE2_URI); Line 33: } Line 34: } -- To view, visit http://gerrit.ovirt.org/37299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If09285f0e6cd8909f21aa7e88ae1a3c1a30763c2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
