Kanagaraj M has posted comments on this change. Change subject: engine: sync job for gluster disk provisioning ......................................................................
Patch Set 9: (6 comments) https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 123: deviceUuidToDeviceMap.get(storageDevice.getDevUuid() deviceUuidToDeviceMap.get(storageDevice.getDevUuid()) can be extracted to a local field to improve re-usablity/readability) Line 129: nameToDeviceMap.get(storageDevice.getName() same here https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java: Line 120: DEVICE_WITHOUT_ANYCHANGE DEVICE_WITH_NAME_CHANGE https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 400: STORAGE_DEVICE_REMOVED_FROM_THE_SYSTEM STORAGE_DEVICE_REMOVED_FROM_THE_HOST https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 314: 1440 1432? https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 829: Removed the storage device ${storageDevice} from host ${VdsName} This looks like a destructive message. Can this be changed to something similar to what happens when volume is removed using CLI. "Detected deletion of volume ${glusterVolumeName} on cluster ${VdsGroupName}, and deleted it from engine DB." -- To view, visit https://gerrit.ovirt.org/36429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
