Ramesh N has posted comments on this change. Change subject: engine: sync job for gluster disk provisioning ......................................................................
Patch Set 10: (8 comments) https://gerrit.ovirt.org/#/c/36429/10/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 155: updateAllInPatch > %s/updateAllInPatch/updateAllInBatch/g Done Line 164: getStorageDeviceDao > We can use removeAll here and pass a Collection of ids as parameter Changed my DAO to implement MassOperationDao. I can call removeAllInBatch() https://gerrit.ovirt.org/#/c/36429/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDao.java: Line 13: StorageDeviceDao > Add a method removeAll with collection of ids as param and use the same in Changed my Dao to implement MassOperationsDao and moved the change to DAO patch https://gerrit.ovirt.org/#/c/36428/7 Line 17: updateAllInPatch > %s/updateAllInPatch/updateAllInBatch/g Changed my Dao to implement MassOperationsDao and moved the change to DAO patch https://gerrit.ovirt.org/#/c/36428/7 https://gerrit.ovirt.org/#/c/36429/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDaoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/StorageDeviceDaoDbFacadeImpl.java: Line 120: updateAllInPatch > %s/updateAllInPatch/updateAllInBatch/g Changed my Dao to implement MassOperationsDao and moved the change to DAO patch https://gerrit.ovirt.org/#/c/36428/7 https://gerrit.ovirt.org/#/c/36429/10/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1168: ACTION_TYPE_FAILED_STORAGE_PROVISIONING_NOT_SUPPORTED_BY_CLUSTER > Use "Cannot ${action} ${type}" as you now have the variables defined. Set t Done https://gerrit.ovirt.org/#/c/36429/10/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 828: add > added Done https://gerrit.ovirt.org/#/c/36429/10/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3134: DefaultStringValue > Same as earlier Done -- To view, visit https://gerrit.ovirt.org/36429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
