Ramesh N has posted comments on this change. Change subject: engine: sync job for gluster disk provisioning ......................................................................
Patch Set 9: (10 comments) https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJob.java: Line 83: else > Below could have been logged by VDS layer already?? I see this code in other places. I am not sure about this getting logged in VDS layer. Line 123: deviceUuidToDeviceMap.get(storageDevice.getDevUuid() > deviceUuidToDeviceMap.get(storageDevice.getDevUuid()) can be extracted to a Done Line 125: getStorageDeviceDao > Try to use updateAllInBatch mechanism Will do that Line 129: nameToDeviceMap.get(storageDevice.getName() > same here Done https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/SyncStorageDevicesCommand.java: Line 21: getDbFacade > possible npe for cluster I am not sure how NPE is possible here. Can there be a host without cluster? https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StorageDeviceSyncJobTest.java: Line 120: DEVICE_WITHOUT_ANYCHANGE > DEVICE_WITH_NAME_CHANGE Done https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java: Line 400: STORAGE_DEVICE_REMOVED_FROM_THE_SYSTEM > STORAGE_DEVICE_REMOVED_FROM_THE_HOST Done https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java: Line 314: 1440 > 1432? Done https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1162: ACTION_TYPE_FAILED_GEOREP_SESSION_STOPPED=Cannot ${action} ${type}. Geo-replication session is stopped. Line 1163: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_STARTED=Cannot ${action} ${type}. Geo-replication session is already started. Line 1164: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_RESUMED=Cannot ${action} ${type}. Geo-replication session is resumed. Line 1165: ACTION_TYPE_FAILED_GEOREP_SESSION_ALREADY_PAUSED=Cannot ${action} ${type}. Geo-replication session is paused. Line 1166: ACTION_TYPE_FAILED_STORAGE_PROVISIONING_NOT_SUPPORTED_BY_CLUSTER=Cannot sync Storage Devices. The selected cluster doesn't support Storage provisioning. > All the messages start with "Cannot ${action} ${type}." Done Line 1167: Line 1168: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1169: Line 1170: ACTION_TYPE_FAILED_QOS_CPU_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range\n(Legal range is: 1-100). https://gerrit.ovirt.org/#/c/36429/9/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 829: Removed the storage device ${storageDevice} from host ${VdsName} > This looks like a destructive message. Done -- To view, visit https://gerrit.ovirt.org/36429 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I651bb51873a96d491c5a5f51147cb72be958985a Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
