Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38547/5/src/plugins/ovirt-host-deploy/hosted-engine/packages.py File src/plugins/ovirt-host-deploy/hosted-engine/packages.py: Line 49: @plugin.event( Line 50: stage=plugin.Stages.STAGE_INIT, Line 51: ) Line 52: def _init(self): Line 53: self.environment[odeploycons.HostedEngineEnv.ENABLE] = False setdefault Line 54: Line 55: @plugin.event( Line 56: stage=plugin.Stages.STAGE_PACKAGES, Line 57: condition=lambda self: self.environment[ Line 64: @plugin.event( Line 65: stage=plugin.Stages.STAGE_CLOSEUP, Line 66: ) Line 67: def _closeup(self): Line 68: self.logger.info(_('Enabling and starting HA services')) not sure this comment is required also you should do this only if enabled Line 69: for service in ( Line 70: odeploycons.Const.HA_AGENT_SERVICE, Line 71: odeploycons.Const.HA_BROCKER_SERVICE, Line 72: ): -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
