Alon Bar-Lev has posted comments on this change. Change subject: hosted-engine: WIP - allow to deploy hosted-engine ......................................................................
Patch Set 5: (2 comments) I do not understand... if we can stop vdsm/libvirt and almost any other service, why can't we stop this one? if there is a host deployed and we want to re-deploy it within new engine, currently we can do that without any issue, while now you will forcibly fail that, fallback into manual interaction. https://gerrit.ovirt.org/#/c/38547/5/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py: Line 96: odeploycons.FileLocations.VDSM_SPICE_CA_FILE Line 97: ), Line 98: 'fqdn': self.environment[ Line 99: odeploycons.VdsmEnv.ENGINE_HOST Line 100: ], this should be set explicitly by engine as well, it can be same as other information engine has. Line 101: 'service_start_time': odeploycons.Const.HOSTED_ENGINE_START_TIME, Line 102: } Line 103: for env_key in self.environment: Line 104: if env_key.startswith( Line 113: for key, value in conf.iteritems(): Line 114: content += '{key}={value}\n'.format( Line 115: key=key, Line 116: value=value, Line 117: ) I am unsure why you first put within a map then create the content. you can create the static content as-is then concat the dynamic content. Line 118: Line 119: self.environment[otopicons.CoreEnv.MAIN_TRANSACTION].append( Line 120: filetransaction.FileTransaction( Line 121: name=odeploycons.FileLocations.HOSTED_ENGINE_CONF, -- To view, visit https://gerrit.ovirt.org/38547 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
