Sandro Bonazzola has posted comments on this change.

Change subject: hosted-engine: WIP - allow to deploy hosted-engine
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/38547/3/src/plugins/ovirt-host-deploy/hosted-engine/configureha.py
File src/plugins/ovirt-host-deploy/hosted-engine/configureha.py:

Line 201:             ],
Line 202:             'sdUUID': self.environment[
Line 203:                 odeploycons.HostedEngineEnv.SD_UUID
Line 204:             ],
Line 205:             'service_start_time': 
odeploycons.Const.HOSTED_ENGINE_START_TIME,
> I do not see it in the source so it is probably safe to remove.
Ok, removing.
Line 206:             'spUUID': self.environment[
Line 207:                 odeploycons.HostedEngineEnv.SP_UUID
Line 208:             ],
Line 209:             'storage': self.environment[


-- 
To view, visit https://gerrit.ovirt.org/38547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07992ccab2f745879c8d3d777e45b524bbdf6f8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-host-deploy
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to