Maor Lipchuk has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 415: public static boolean
checkImageConfiguration(storage_domain_static storageDomain,
Line 416: DiskImageBase diskInfo, List<String> messages, boolean
isCopyCollapse) {
Line 417: boolean result = true;
Line 418: if ((diskInfo.getvolume_type() == VolumeType.Preallocated &&
diskInfo.getvolume_format() == VolumeFormat.COW)
Line 419: || !isCopyCollapse &&
isVolTypeAndFormatSupportedByBlockDevice(storageDomain, diskInfo)
done
Line 420: || (diskInfo.getvolume_format() ==
VolumeFormat.Unassigned || diskInfo.getvolume_type() == VolumeType.Unassigned))
{
Line 421: // not supported
Line 422: result = false;
Line 423:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_DISK_CONFIGURATION_NOT_SUPPORTED.toString());
Line 424: }
Line 425: return result;
Line 426: }
Line 427:
Line 428: private static boolean
isVolTypeAndFormatSupportedByBlockDevice(storage_domain_static storageDomain,
I think it will be misleading. This method is only for block device.
Line 429: DiskImageBase diskInfo) {
Line 430: return (storageDomain.getstorage_type() == StorageType.FCP ||
storageDomain.getstorage_type() == StorageType.ISCSI) && (diskInfo
Line 431: .getvolume_type() == VolumeType.Sparse &&
diskInfo.getvolume_format() == VolumeFormat.RAW);
Line 432: }
--
To view, visit http://gerrit.ovirt.org/7756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
