Ayal Baron has posted comments on this change.
Change subject: core:Import VM should not be blocked when collapse.(#766657)
......................................................................
Patch Set 7: Looks good to me, but someone else must approve
(6 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 228: }
Line 229: if (p.getvolume_type() != null) {
Line 230:
image.setvolume_type(p.getvolume_type());
Line 231: }
Line 232: retVal =
validateImageConfiguration(canDoActionMessages, domainsMap, image);
missing break here.
missing comment explaining when and why validateImageConfig is run.
Line 233: }
Line 234: }
Line 235: } else {
Line 236: retVal =
validateImageConfiguration(canDoActionMessages, domainsMap, image);
....................................................
Commit Message
Line 7: core:Import VM should not be blocked when collapse.(#766657)
Line 8:
Line 9: https://bugzilla.redhat.com/766657
Line 10:
Line 11: Import VM to block-device domain should not be blocked for
s/-device//g
Line 12: images which have sparse volume type and RAW volume format,
Line 13: if user sends copy collapse option as true.
Line 14:
Line 15: Block-Device does not support RAW sparse volumes, so disk with snapshot
Line 9: https://bugzilla.redhat.com/766657
Line 10:
Line 11: Import VM to block-device domain should not be blocked for
Line 12: images which have sparse volume type and RAW volume format,
Line 13: if user sends copy collapse option as true.
has nothing to do with collapse, user chooses the target format and we need to
verify it is legal.
Line 14:
Line 15: Block-Device does not support RAW sparse volumes, so disk with snapshot
Line 16: can not be imported to ISCSI domain.
Line 17: If user will choose to copy collapse the image then the volume will
Line 11: Import VM to block-device domain should not be blocked for
Line 12: images which have sparse volume type and RAW volume format,
Line 13: if user sends copy collapse option as true.
Line 14:
Line 15: Block-Device does not support RAW sparse volumes, so disk with snapshot
s/Block-device does not/Block storage domains do not/
Line 16: can not be imported to ISCSI domain.
Line 17: If user will choose to copy collapse the image then the volume will
Line 18: become cow sparse or raw preallocated (Depends on the user decision),
Line 19: which are supported by the target block-device domain.
Line 12: images which have sparse volume type and RAW volume format,
Line 13: if user sends copy collapse option as true.
Line 14:
Line 15: Block-Device does not support RAW sparse volumes, so disk with snapshot
Line 16: can not be imported to ISCSI domain.
a disk with snapshots *can* be imported to block domains.
The problem is what the format and allocation policy of the base volume are.
Line 17: If user will choose to copy collapse the image then the volume will
Line 18: become cow sparse or raw preallocated (Depends on the user decision),
Line 19: which are supported by the target block-device domain.
Line 20:
Line 14:
Line 15: Block-Device does not support RAW sparse volumes, so disk with snapshot
Line 16: can not be imported to ISCSI domain.
Line 17: If user will choose to copy collapse the image then the volume will
Line 18: become cow sparse or raw preallocated (Depends on the user decision),
I think API allows to choose the format as well so this is incorrect.
Line 19: which are supported by the target block-device domain.
Line 20:
Line 21: The proposed fix, performs the validation, only in two cases:
Line 22: 1. When user send copy collapse as true, and only on disks which their
--
To view, visit http://gerrit.ovirt.org/7756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
