Maor Lipchuk has posted comments on this change. Change subject: core:Import VM should not be blocked when collapse. ......................................................................
Patch Set 6: (1 inline comment) .................................................... Commit Message Line 7: core:Import VM should not be blocked when collapse. Line 8: Line 9: Import VM with disks to block-device domain will not be blocked for Line 10: images which have sparse volume type and RAW volume format, Line 11: if user sends copy collapse option as true. I'm not sure I'm following. The comparison the engine does is being done on the image and storage domain fetched from the DB, we don't count on what the user sent us on validation except the copy collapse indication. Line 12: Line 13: Block-Device does not support RAW sparse volumes, so disk with snapshot Line 14: can not be imported to ISCSI domain. Line 15: If user will choose to copy collapse the image then the volume will -- To view, visit http://gerrit.ovirt.org/7756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6f4b762fbd9770c5157fee6b24373fa9a0dca10 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
