Michael Kublin has posted comments on this change.
Change subject: core: unified code for matching VDS (#855776)
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 177: /**
Line 178: * save vdsVersion in order to know vds version that was wrong
Line 179: */
Line 180: RpmVersion vdsVersion = null;
Line 181: boolean noVDSs = true;
why not use StringBuilder?
Line 182: StringBuffer sb = new StringBuffer();
Line 183: for (VDS curVds : vdss) {
Line 184: if (isMigrate && getVm().getrun_on_vds() != null &&
getVm().getrun_on_vds().equals(curVds.getId())) {
Line 185: continue;
Line 310: .<Integer>
GetValue(ConfigValues.BlockMigrationOnSwapUsagePercentage);
Line 311: }
Line 312:
Line 313: private Guid getVdsToRunOn(Iterable<VDS> vdss) {
Line 314: StringBuffer sb = new StringBuffer();
Maybe better to use StringBuilder?
Line 315: final List<VDS> readyToRun = new ArrayList<VDS>();
Line 316: for (VDS curVds : vdss) {
Line 317: if (validateHostIsReadyToRun(curVds,sb) ==
ValidationResult.VALID) {
Line 318: readyToRun.add(curVds);
--
To view, visit http://gerrit.ovirt.org/7921
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic82521368a4f3c3c518c8cf4e5dc460b9e54f381
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
