Roy Golan has posted comments on this change.

Change subject: core: unified code for matching VDS (#855776)
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsSelector.java
Line 310:                 .<Integer> 
GetValue(ConfigValues.BlockMigrationOnSwapUsagePercentage);
Line 311:     }
Line 312: 
Line 313:     private Guid getVdsToRunOn(Iterable<VDS> vdss) {
Line 314:         StringBuffer sb = new StringBuffer();
Yes I confused it with Builder. will switch
Line 315:         final List<VDS> readyToRun = new ArrayList<VDS>();
Line 316:         for (VDS curVds : vdss) {
Line 317:             if (validateHostIsReadyToRun(curVds,sb) == 
ValidationResult.VALID) {
Line 318:                 readyToRun.add(curVds);


--
To view, visit http://gerrit.ovirt.org/7921
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic82521368a4f3c3c518c8cf4e5dc460b9e54f381
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to