Itamar Heim has posted comments on this change.
Change subject: Trust the SpmStart task result during election
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java
Line 112: }
Line 113:
Line 114: private void logException(RuntimeException ex) {
Line 115: log.errorFormat("Command {0} execution failed. Exception:
{1}", getCommandName(), ExceptionUtils.getMessage(ex));
Line 116: if (!(ex instanceof VDSExceptionBase)) {
1. yes, I think it should be in a separate patch
2. i'm fine with it in general, as long as you are ready to accept a slew of
bugs on filtering the exception for all the use cases there was no reason to
call "help, i got an exception in my logs"
3. hence, maybe this should be at debug level.
Line 117: log.error(ExceptionUtils.getStackTrace(ex));
Line 118: }
Line 119: }
Line 120:
--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
