Allon Mureinik has posted comments on this change.
Change subject: core: trust the SpmStart task result during election
......................................................................
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java
Line 52: .runVdsCommand(VDSCommandType.HSMGetTaskStatus,
Line 53: new
HSMTaskGuidBaseVDSCommandParameters(getVds().getId(), taskId)).getReturnValue();
Line 54: log.debugFormat("spmStart polling - task status: {0}",
taskStatus.getStatus().toString());
Line 55: } while (taskStatus.getStatus() != AsyncTaskStatusEnum.finished
Line 56: && taskStatus.getStatus() !=
AsyncTaskStatusEnum.unknown);
This block should be refactored to /dev/null, and the conventional handling of
tasks, with endSuccessfully() should be used.
But I guess this patch really isn't the place for that...
Line 57:
Line 58: log.infoFormat("spmStart polling ended: taskId = {0}, result =
{1}, status = {2}, message = {3}", taskId,
Line 59: taskStatus.getResult().toString(),
taskStatus.getStatus(), taskStatus.getMessage());
Line 60:
--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
