Federico Simoncelli has posted comments on this change.
Change subject: core: trust the SpmStart task result during election
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStartVDSCommand.java
Line 52: .runVdsCommand(VDSCommandType.HSMGetTaskStatus,
Line 53: new
HSMTaskGuidBaseVDSCommandParameters(getVds().getId(), taskId)).getReturnValue();
Line 54: log.debugFormat("spmStart polling - task status: {0}",
taskStatus.getStatus().toString());
Line 55: } while (taskStatus.getStatus() != AsyncTaskStatusEnum.finished
Line 56: && taskStatus.getStatus() !=
AsyncTaskStatusEnum.unknown);
Yes the only problem that I can think of is that in this case the host is not
strictly the SPM (it's in the startSpm process). Theoretically I suppose that
the correct description for the current async tasks should be "you can run
async tasks on only one host" (rather than "on the SPM only"), therefore they
can be used in this case too, I'm just not sure if there's anything that would
get in the way (eg: if you have to mark this host as the SPM before initiating
the startSpm task, what about the db? the task would be registered there at
that point... etc...). Definitely not for this patch.
Line 57:
Line 58: log.infoFormat("spmStart polling ended: taskId = {0}, result =
{1}, status = {2}, message = {3}", taskId,
Line 59: taskStatus.getResult().toString(),
taskStatus.getStatus(), taskStatus.getMessage());
Line 60:
--
To view, visit http://gerrit.ovirt.org/8072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I832957996226cf091b1b7fe8fa3cc7657507795a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
