Dhandapani Gopal has posted comments on this change.

Change subject: engine: Get Volume Advanced Details Query
......................................................................


Patch Set 16: (2 inline comments)

Incorporated review comments.

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeAdvancedDetailsQuery.java
Line 89:         return ClusterUtils.getInstance();
Line 90:     }
Line 91: 
Line 92:     protected VDSBrokerFrontend getBackendResourceManager() {
Line 93:         return Backend.getInstance()
Done
Line 94:                 .getResourceManager();
Line 95:     }


....................................................
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeAdvancedDetailsVDSCommand.java
Line 23:     }
Line 24: 
Line 25:     @Override
Line 26:     protected void ExecuteVdsBrokerCommand() {
Line 27:         GlusterVolumeAdvancedDetails volumeAdvancedDetails = new 
GlusterVolumeAdvancedDetails();
Done
Line 28:         executeVolumeStatusInfo("");
Line 29:         volumeAdvancedDetails = result.getVolumeAdvancedDetails();
Line 30: 
Line 31:         if (getParameters().detailsRequired()) {


--
To view, visit http://gerrit.ovirt.org/7807
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If6b590eaebeb1d06b7278300d5e12b2dab9eb093
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Dhandapani Gopal <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Selvasundaram <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to