Ayal Baron has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/SetStoragePoolStatusCommand.java
Line 48: public AuditLogType getAuditLogTypeValue()
{
Line 49: return
AuditLogType.STORAGE_DOMAIN_TASKS_ERROR;
Line 50: }
Line 51:
Line 52: };
why is this created inside the for loop?
Line 53:
auditLogableBase.setStorageDomain(getStorageDomain());
Line 54: auditLogableBase.setJobId(taskId);
Line 55: AuditLogDirector.log(auditLogableBase);
Line 56: }
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 516: RELOAD_CONFIGURATIONS_SUCCESS=System Configurations reloaded
successfully.
Line 517: RELOAD_CONFIGURATIONS_FAILURE=System Configurations failed to reload.
Line 518: USER_ACCOUNT_DISABLED_OR_LOCKED=User ${UserName} cannot login, as it
got disabled or locked. Please contact the system administrator.
Line 519: USER_ACCOUNT_PASSWORD_EXPIRED=User ${UserName} cannot login, as the
user account password has expired. Please contact the system administrator.
Line 520: STORAGE_DOMAIN_TASKS_ERROR=Storage domain is down while there are
tasks running on it. These tasks may fail.
Please phrase as follows:
'An error has been encountered with Storage Domain X while there were tasks
accessing it. These tasks might fail.'
Obviously need to substitute X with domain name/uuid.
Also, if we could refer the user to someplace in the GUI where more information
can be found (which tasks these are for instance) that would be even better.
Line 521: IMPORTEXPORT_IMPORT_VM_INVALID_INTERFACES=While importing VM
${VmName}, the Network/s ${Networks} were found to be Non-VM Networks or do not
exist in Cluster. Network Name was not set in the Interface/s ${Interfaces}.
Line 522: IMPORTEXPORT_IMPORT_TEMPLATE_INVALID_INTERFACES=While importing
Template ${VmTemplateName}, the Network/s ${Networks} were found to be Non-VM
Networks or do not exist in Cluster. Network Name was not set in the
Interface/s ${Interfaces}.
Line 523: VDS_SET_NON_OPERATIONAL_VM_NETWORK_IS_BRIDGELESS=Host ${VdsName} does
not comply with the cluster ${VdsGroupName} networks, the following VM networks
are bridgeless: '${Networks}'
Line 524: # Gluster Messages
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
