Federico Simoncelli has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
Adding a suggestion and a question.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 234: }
Line 235:
Line 236: /**
Line 237: * Send notification to user about tasks still running at the
moment when the storage got deactivated.
Line 238: */
We probably need to get rid of the getstorage_domain_type() check in the
canDoAction. If understand correctly we want to prevent to move down a domain
that has running tasks (regardless of the type). So the two tests of the
canDoAction would be:
1. if we're moving down the master domain check that there are no active tasks
in the entire pool (this is already present in the current code)
2. check if the domain that we want to move down has a running task (now we
filter per ISO type but instead we should do it for all the types)
Is there any situation where we want to force the action even if there are
running tasks and therefore just notify it? (as this patch is doing)
Line 239: private void notifyAsyncTasks() {
Line 240: final List<Guid> asyncTasks =
Line 241: getDbFacade().getAsyncTaskDao()
Line 242:
.getAsyncTaskIdsByEntity(getParameters().getStorageDomainId());
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
