Ayal Baron has posted comments on this change.
Change subject: core: notify user about broken domain tasks (#753591)
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java
Line 234: }
Line 235:
Line 236: /**
Line 237: * Send notification to user about tasks still running at the
moment when the storage got deactivated.
Line 238: */
Just to make things clear, there are 2 situations:
1. user pushed the 'Maintenance' button
2. domain is reported in error state
Maintenance should be prevented on *any* domain which has tasks.
Error state should be allowed for export and iso domains (truth is it should
always be allowed but that's not for this patch)
Line 239: private void notifyAsyncTasks() {
Line 240: final List<Guid> asyncTasks =
Line 241: getDbFacade().getAsyncTaskDao()
Line 242:
.getAsyncTaskIdsByEntity(getParameters().getStorageDomainId());
--
To view, visit http://gerrit.ovirt.org/7957
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b6239668eece2be39b96c9bd360af2bd310a3b0
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
