Vered Volansky has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 190: return null;
Line 191: }
Line 192: });
Line 193: } catch (VdcBLLException e) {
Line 194: if (e.getErrorCode() != VdcBllErrors.SNAPSHOT_FAILED) {
I prefer a positive condition with else, but I guess it's a matter of style
Line 195: throw e;
Line 196: }
Line 197: handleVdsLiveSnapshotFailure(e);
Line 198:
Line 194: if (e.getErrorCode() != VdcBllErrors.SNAPSHOT_FAILED) {
Line 195: throw e;
Line 196: }
Line 197: handleVdsLiveSnapshotFailure(e);
Line 198:
redundant empty line
Line 199: }
Line 200: }
Line 201:
Line 202: private void handleVdsLiveSnapshotFailure(VdcBLLException e) {
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 37: USER_EJECT_VM_DISK=CD was ejected from VM ${VmName} by ${UserName}
Line 38: USER_CREATE_SNAPSHOT=Snapshot ${SnapshotName} creation for VM
${VmName} was initiated by ${UserName}.
Line 39: USER_CREATE_SNAPSHOT_FINISHED_SUCCESS=Snapshot ${SnapshotName}
creation for VM ${VmName} has been completed.
Line 40: USER_CREATE_SNAPSHOT_FINISHED_FAILURE=Failed to complete Snapshot
${SnapshotName} creation for VM ${VmName}.
Line 41: USER_CREATE_LIVE_SNAPSHOT_FINISHED_FAILURE=Failed to configured VM
${VmName} with Live-Snapshot ${SnapshotName}. VM restart is recommended.
s/configured/configure
Line 42: USER_REMOVE_SNAPSHOT=Snapshot ${SnapshotName} deletion on VM ${VmName}
was initiated by ${UserName}.
Line 43: USER_REMOVE_SNAPSHOT_FINISHED_SUCCESS=Snapshot ${SnapshotName}
deletion on VM ${VmName} has been completed.
Line 44: USER_REMOVE_SNAPSHOT_FINISHED_FAILURE=Failed to complete Snapshot
${SnapshotName} deletion on VM ${VmName}.
Line 45: USER_DETACH_USER_FROM_POOL=User ${AdUserName} was detached from VM
Pool ${VmPoolName} by ${UserName}.
--
To view, visit http://gerrit.ovirt.org/9390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
