Allon Mureinik has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 201: private void handleVdsLiveSnapshotFailure(VdcBLLException e) {
Line 202: log.warnFormat("Wasn't able to live snpashot due to error:
{0}. VM will still be configured to the new created snapshot",
Line 203: ExceptionUtils.getMessage(e));
Line 204: AddCustomValue("SnapshotName", getSnapshotName());
Line 205: AddCustomValue("VmName", getVmName());
wouldn't you get these two "for free" since you have getters for them?
Line 206: AuditLogDirector.log(this,
AuditLogType.USER_CREATE_LIVE_SNAPSHOT_FINISHED_FAILURE);
Line 207: }
Line 208:
Line 209: /**
--
To view, visit http://gerrit.ovirt.org/9390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
