Maor Lipchuk has posted comments on this change.
Change subject: core:End failed live snapshot with warning.
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 190: return null;
Line 191: }
Line 192: });
Line 193: } catch (VdcBLLException e) {
Line 194: if (e.getErrorCode() != VdcBllErrors.SNAPSHOT_FAILED) {
I usually tend to agree with that philosophy. but I also prefer to use shorter
statements. Perhaps a refactor to an external method might make it more clear.
Line 195: throw e;
Line 196: }
Line 197: handleVdsLiveSnapshotFailure(e);
Line 198:
--
To view, visit http://gerrit.ovirt.org/9390
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
