Liron Aravot has posted comments on this change.
Change subject: core: ImprotVm: disk alias with copyCollapse=false
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 729: * Save a snapshot if it does not exist in the database.
Line 730: * @param snapshotId The snapshot to save.
Line 731: * @param disk The disk containing the snapshot's information.
Line 732: */
Line 733: protected void saveSnapshot(Guid snapshotId, DiskImage disk) {
this if should be outside of the method or the method name should reflect that
it might not perform save
Line 734: if (!getSnapshotDao().exists(getVm().getId(), snapshotId)) {
Line 735: getSnapshotDao().save(
Line 736: new Snapshot(snapshotId,
Line 737: SnapshotStatus.OK,
Line 746:
Line 747: /**
Line 748: * Update a snapshot and make it the active snapshot.
Line 749: * @param snapshotId The snapshot to update.
Line 750: */
/s/updaet/update
Line 751: protected void updaetActiveSnapshot(Guid snapshotId) {
Line 752: getSnapshotDao().update(
Line 753: new Snapshot(snapshotId,
Line 754: SnapshotStatus.OK,
....................................................
Commit Message
Line 2: Author: Allon Mureinik <[email protected]>
Line 3: AuthorDate: 2012-12-02 11:09:42 +0200
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2012-12-02 11:24:38 +0200
Line 6:
/s/Improt/Import
Line 7: core: ImprotVm: disk alias with copyCollapse=false
Line 8:
Line 9: Added disk aliases in ImportVmCommand when copyCollapse=false.
Line 10:
--
To view, visit http://gerrit.ovirt.org/9631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03699ece4d20f2d20beb791c3cb1518e39c4d1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
