Liron Aravot has posted comments on this change.
Change subject: core: ImportVm: disk alias with copyCollapse=false
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 728: /**
Line 729: * Save a snapshot if it does not exist in the database.
Line 730: * @param snapshotId The snapshot to save.
Line 731: * @param disk The disk containing the snapshot's information.
Line 732: */
maybe NotExists? the name is a bit misleading in my opinion..and that's what
the if clause checks before saving
Line 733: protected void saveSnapshotIfExists(Guid snapshotId, DiskImage
disk) {
Line 734: if (!getSnapshotDao().exists(getVm().getId(), snapshotId)) {
Line 735: getSnapshotDao().save(
Line 736: new Snapshot(snapshotId,
--
To view, visit http://gerrit.ovirt.org/9631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03699ece4d20f2d20beb791c3cb1518e39c4d1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
