Ayal Baron has posted comments on this change.

Change subject: core: ImportVm: disk alias with copyCollapse=false
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 663:                 DiskImage disk = diskList.get(diskList.size() - 1);
Line 664:                 snapshotId = disk.getvm_snapshot_id().getValue();
Line 665:                 disk.setactive(true);
Line 666:                 ++aliasCounter;
Line 667:                 ImagesHandler.setDiskAlias(disk, getVm(), 
aliasCounter);
increment inline?
Line 668:                 updateImage(disk);
Line 669:                 saveBaseDisk(disk);
Line 670:             }
Line 671: 


--
To view, visit http://gerrit.ovirt.org/9631
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f03699ece4d20f2d20beb791c3cb1518e39c4d1
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to