Liron Aravot has posted comments on this change. Change subject: core: ImportVm test cleanup: make constant static ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmCommandTest.java Line 68: v.setDiskSize(2); Line 69: return v; Line 70: } Line 71: Line 72: private static final String string100 = "0987654321" + yep, that'll do the trick as well :-) I like leftPad better as it let you to define the chars count and not to be dependent on the length of the string you chose (number of repetitions) ..but in that usecase it doesn't really matter. Line 73: "0987654321" + Line 74: "0987654321" + Line 75: "0987654321" + Line 76: "0987654321" + -- To view, visit http://gerrit.ovirt.org/9619 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f04e067e8bce2c6cd1010f83a44809a3c8c464c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
